{
  "code": null,
  "collection": "architecture",
  "href": "https://banes-lab.com/ontology#architecture-code-review",
  "id": "code-review",
  "kind": "activity",
  "layer": {
    "href": "https://banes-lab.com/ontology/schema#layer-evolution-principles",
    "json": "https://banes-lab.com/json/records/layer/evolution-principles",
    "label": "Evolution Principles",
    "markdown": "https://banes-lab.com/records/layer/evolution-principles.md",
    "ref": "layer:evolution-principles"
  },
  "name": "Code Review",
  "ref": "architecture:code-review",
  "relations": [
    {
      "links": [
        {
          "href": "https://banes-lab.com/ontology/lexicon#lexicon-review-standards",
          "json": "https://banes-lab.com/json/records/lexicon/review-standards",
          "label": "Review Standards",
          "markdown": "https://banes-lab.com/records/lexicon/review-standards.md",
          "ref": "lexicon:review-standards"
        }
      ],
      "relation": "requires"
    },
    {
      "links": [
        {
          "href": "https://banes-lab.com/ontology/lexicon#lexicon-quality",
          "json": "https://banes-lab.com/json/records/lexicon/quality",
          "label": "Quality",
          "markdown": "https://banes-lab.com/records/lexicon/quality.md",
          "ref": "lexicon:quality"
        },
        {
          "href": "https://banes-lab.com/ontology/lexicon#lexicon-security",
          "json": "https://banes-lab.com/json/records/lexicon/security",
          "label": "Security",
          "markdown": "https://banes-lab.com/records/lexicon/security.md",
          "ref": "lexicon:security"
        },
        {
          "href": "https://banes-lab.com/ontology#architecture-consistency",
          "json": "https://banes-lab.com/json/records/architecture/consistency",
          "label": "Consistency",
          "markdown": "https://banes-lab.com/records/architecture/consistency.md",
          "ref": "architecture:consistency"
        }
      ],
      "relation": "reinforces"
    },
    {
      "links": [
        {
          "href": "https://banes-lab.com/ontology/lexicon#lexicon-defect-detection",
          "json": "https://banes-lab.com/json/records/lexicon/defect-detection",
          "label": "Defect Detection",
          "markdown": "https://banes-lab.com/records/lexicon/defect-detection.md",
          "ref": "lexicon:defect-detection"
        }
      ],
      "relation": "enables"
    },
    {
      "links": [
        {
          "href": "https://banes-lab.com/ontology/lexicon#lexicon-direct-to-main-unreviewed-change",
          "json": "https://banes-lab.com/json/records/lexicon/direct-to-main-unreviewed-change",
          "label": "Direct-to-main Unreviewed Change",
          "markdown": "https://banes-lab.com/records/lexicon/direct-to-main-unreviewed-change.md",
          "ref": "lexicon:direct-to-main-unreviewed-change"
        }
      ],
      "relation": "conflicts-with"
    },
    {
      "links": [
        {
          "href": "https://banes-lab.com/ontology#architecture-throughput",
          "json": "https://banes-lab.com/json/records/architecture/throughput",
          "label": "Throughput",
          "markdown": "https://banes-lab.com/records/architecture/throughput.md",
          "ref": "architecture:throughput"
        }
      ],
      "relation": "tensions-with"
    },
    {
      "links": [
        {
          "href": "https://banes-lab.com/ontology/schema#tension-code-review-throughput",
          "json": "https://banes-lab.com/json/records/tension/code-review-throughput",
          "label": "Code Review / Throughput",
          "markdown": "https://banes-lab.com/records/tension/code-review-throughput.md",
          "ref": "tension:code-review-throughput"
        }
      ],
      "relation": "tensions"
    },
    {
      "links": [
        {
          "href": "https://banes-lab.com/ontology/lexicon#lexicon-direct-to-main-unreviewed-change",
          "json": "https://banes-lab.com/json/records/lexicon/direct-to-main-unreviewed-change",
          "label": "Direct-to-main Unreviewed Change",
          "markdown": "https://banes-lab.com/records/lexicon/direct-to-main-unreviewed-change.md",
          "ref": "lexicon:direct-to-main-unreviewed-change"
        }
      ],
      "relation": "violated-by"
    },
    {
      "links": [
        {
          "href": "https://banes-lab.com/ontology/schema#vocabulary-severity-mandatory",
          "json": "https://banes-lab.com/json/records/vocabulary/severity-mandatory",
          "label": "mandatory",
          "markdown": "https://banes-lab.com/records/vocabulary/severity-mandatory.md",
          "ref": "vocabulary:severity-mandatory"
        }
      ],
      "relation": "severity"
    },
    {
      "links": [
        {
          "href": "https://banes-lab.com/ontology#architecture-category-architecture-review-evolution-governance-artifacts",
          "json": "https://banes-lab.com/json/records/architecture-category/architecture-review-evolution-governance-artifacts",
          "label": "Architecture Review / Evolution / Governance Artifacts",
          "markdown": "https://banes-lab.com/records/architecture-category/architecture-review-evolution-governance-artifacts.md",
          "ref": "architecture-category:architecture-review-evolution-governance-artifacts"
        }
      ],
      "relation": "category"
    },
    {
      "links": [
        {
          "href": "https://banes-lab.com/anatomy/content#file-content-runtime-entrypoints-writing-entrypoint-ts",
          "json": "https://banes-lab.com/json/source/content/runtime/entrypoints/writing.entrypoint.ts",
          "label": "runtime/entrypoints/writing.entrypoint.ts",
          "markdown": "https://banes-lab.com/source/content/runtime/entrypoints/writing.entrypoint.ts.md",
          "ref": "anatomy:file-content-runtime-entrypoints-writing-entrypoint-ts"
        }
      ],
      "relation": "enforced-by"
    },
    {
      "links": [
        {
          "href": "https://banes-lab.com/ontology#architecture-architecture-review",
          "json": "https://banes-lab.com/json/records/architecture/architecture-review",
          "label": "Architecture Review",
          "markdown": "https://banes-lab.com/records/architecture/architecture-review.md",
          "ref": "architecture:architecture-review"
        },
        {
          "href": "https://banes-lab.com/ontology#architecture-model-safety",
          "json": "https://banes-lab.com/json/records/architecture/model-safety",
          "label": "Model Safety",
          "markdown": "https://banes-lab.com/records/architecture/model-safety.md",
          "ref": "architecture:model-safety"
        },
        {
          "href": "https://banes-lab.com/ontology#architecture-agentic-architecture",
          "json": "https://banes-lab.com/json/records/architecture/agentic-architecture",
          "label": "Agentic Architecture",
          "markdown": "https://banes-lab.com/records/architecture/agentic-architecture.md",
          "ref": "architecture:agentic-architecture"
        }
      ],
      "relation": "refactors"
    },
    {
      "links": [
        {
          "href": "https://banes-lab.com/ontology#architecture-category-correctness-determinism-verification",
          "json": "https://banes-lab.com/json/ontology/principles/architecture-category-correctness-determinism-verification",
          "label": "Correctness / Determinism / Verification",
          "markdown": "https://banes-lab.com/ontology/principles/architecture-category-correctness-determinism-verification.md",
          "ref": "chapter:/ontology#architecture-category-correctness-determinism-verification"
        },
        {
          "href": "https://banes-lab.com/ontology#architecture-category-solid-object-oriented-design",
          "json": "https://banes-lab.com/json/ontology/principles/architecture-category-solid-object-oriented-design",
          "label": "SOLID / Object-Oriented Design",
          "markdown": "https://banes-lab.com/ontology/principles/architecture-category-solid-object-oriented-design.md",
          "ref": "chapter:/ontology#architecture-category-solid-object-oriented-design"
        },
        {
          "href": "https://banes-lab.com/ontology#architecture-category-architecture-review-evolution-governance-artifacts",
          "json": "https://banes-lab.com/json/ontology/principles/architecture-category-architecture-review-evolution-governance-artifacts",
          "label": "Architecture Review / Evolution / Governance Artifacts",
          "markdown": "https://banes-lab.com/ontology/principles/architecture-category-architecture-review-evolution-governance-artifacts.md",
          "ref": "chapter:/ontology#architecture-category-architecture-review-evolution-governance-artifacts"
        },
        {
          "href": "https://banes-lab.com/ontology#architecture-category-model-architecture",
          "json": "https://banes-lab.com/json/ontology/principles/architecture-category-model-architecture",
          "label": "Model Architecture",
          "markdown": "https://banes-lab.com/ontology/principles/architecture-category-model-architecture.md",
          "ref": "chapter:/ontology#architecture-category-model-architecture"
        },
        {
          "href": "https://banes-lab.com/ontology#architecture-category-scalability-performance-optimization",
          "json": "https://banes-lab.com/json/ontology/principles/architecture-category-scalability-performance-optimization",
          "label": "Scalability / Performance / Optimization",
          "markdown": "https://banes-lab.com/ontology/principles/architecture-category-scalability-performance-optimization.md",
          "ref": "chapter:/ontology#architecture-category-scalability-performance-optimization"
        },
        {
          "href": "https://banes-lab.com/ontology#architecture-category-streaming-pipeline-dataflow-processing",
          "json": "https://banes-lab.com/json/ontology/principles/architecture-category-streaming-pipeline-dataflow-processing",
          "label": "Streaming / Pipeline / Dataflow Processing",
          "markdown": "https://banes-lab.com/ontology/principles/architecture-category-streaming-pipeline-dataflow-processing.md",
          "ref": "chapter:/ontology#architecture-category-streaming-pipeline-dataflow-processing"
        },
        {
          "href": "https://banes-lab.com/ontology#architecture-category-transactions-state-concurrency",
          "json": "https://banes-lab.com/json/ontology/principles/architecture-category-transactions-state-concurrency",
          "label": "Transactions / State / Concurrency",
          "markdown": "https://banes-lab.com/ontology/principles/architecture-category-transactions-state-concurrency.md",
          "ref": "chapter:/ontology#architecture-category-transactions-state-concurrency"
        },
        {
          "href": "https://banes-lab.com/ontology/lexicon#lexicon-category-architecture-review-evolution-governance",
          "json": "https://banes-lab.com/json/ontology/lexicon/lexicon-category-architecture-review-evolution-governance",
          "label": "Architecture Review Evolution Governance",
          "markdown": "https://banes-lab.com/ontology/lexicon/lexicon-category-architecture-review-evolution-governance.md",
          "ref": "chapter:/ontology/lexicon#lexicon-category-architecture-review-evolution-governance"
        },
        {
          "href": "https://banes-lab.com/ontology/lexicon#lexicon-category-quality-attributes",
          "json": "https://banes-lab.com/json/ontology/lexicon/lexicon-category-quality-attributes",
          "label": "Quality Attributes",
          "markdown": "https://banes-lab.com/ontology/lexicon/lexicon-category-quality-attributes.md",
          "ref": "chapter:/ontology/lexicon#lexicon-category-quality-attributes"
        },
        {
          "href": "https://banes-lab.com/ontology/schema#the-vocabulary-severity",
          "json": "https://banes-lab.com/json/ontology/schema/the-vocabulary-severity",
          "label": "Severity levels",
          "markdown": "https://banes-lab.com/ontology/schema/the-vocabulary-severity.md",
          "ref": "chapter:/ontology/schema#the-vocabulary-severity"
        },
        {
          "href": "https://banes-lab.com/ontology/schema#the-resolutions",
          "json": "https://banes-lab.com/json/ontology/schema/the-resolutions",
          "label": "The resolutions",
          "markdown": "https://banes-lab.com/ontology/schema/the-resolutions.md",
          "ref": "chapter:/ontology/schema#the-resolutions"
        }
      ],
      "relation": "linked-from"
    }
  ],
  "summary": "The activity of having a second party read a code change against review standards before it merges.",
  "siblings": {
    "next": {
      "href": "https://banes-lab.com/ontology#architecture-impact-analysis",
      "json": "https://banes-lab.com/json/records/architecture/impact-analysis",
      "label": "Impact Analysis",
      "markdown": "https://banes-lab.com/records/architecture/impact-analysis.md",
      "ref": "architecture:impact-analysis"
    },
    "previous": {
      "href": "https://banes-lab.com/ontology#architecture-design-review",
      "json": "https://banes-lab.com/json/records/architecture/design-review",
      "label": "Design Review",
      "markdown": "https://banes-lab.com/records/architecture/design-review.md",
      "ref": "architecture:design-review"
    }
  },
  "up": {
    "href": null,
    "json": "https://banes-lab.com/json/api/records/architecture",
    "label": "Architecture principles",
    "markdown": "https://banes-lab.com/api/records/architecture.md",
    "ref": "api:records/architecture"
  },
  "aliases": [],
  "exemplar": {
    "after": "const review = codeReview(fooChange);\nreview.require({ approvals: 2, passingChecks: [\"tests\", \"types\", \"security\", \"architecture\"] });\ngit.merge(review.approvedCommit);",
    "before": "git.merge(fooChange);",
    "lang": "ts",
    "medium": "code"
  },
  "formedBy": null,
  "scope": [
    "code change"
  ],
  "severity": "mandatory"
}